new feature: object uploading on AWS S3 cloud#6
Merged
Conversation
mohard
requested changes
Jun 18, 2020
|
|
||
| private final URI uri; | ||
| private final UUID id; | ||
| private final String BUCKET_NAME; |
Collaborator
There was a problem hiding this comment.
camel case for class fields
| public AwsInfo(String bucketName, String keyName) { | ||
| BUCKET_NAME = bucketName; | ||
| KEY_NAME = keyName; | ||
| uri = URI.create(BUCKET_NAME + "/" + KEY_NAME); |
| .withCredentials(new AWSStaticCredentialsProvider(awsSecurityCredentials.getCredentials())) | ||
| .withRegion(region) | ||
| .build(); | ||
| } catch (Throwable e) { |
| class BucketCreatorTest { | ||
|
|
||
| private static AmazonS3 awsClient; | ||
| private static String additionalBucket = "com.justyna.lisok.factory.content-bucket-test"; |
| @Test | ||
| void createNonExistingStorageContainersWhenBucketExists() throws AwsContentWritingException { | ||
| //given | ||
| AwsInfo info = new AwsInfo("com.justyna.lisok.factory.content-bucket", "content.json"); |
Collaborator
There was a problem hiding this comment.
ensure the bucket really exists
mohard
approved these changes
Jun 24, 2020
|
|
||
| public class PresignedUrlRequest { | ||
|
|
||
| public GeneratePresignedUrlRequest generateRequest(AwsInfo info, Date expiration) { |
Collaborator
There was a problem hiding this comment.
|
|
||
| public class ServerObjectsManagementService<RawContent, Content> { | ||
|
|
||
| ContentSendingService<RawContent, Content, ContentStorage<String>> sendingService; |
|
|
||
| public class TimeCalculator { | ||
|
|
||
| public Date calculateExpirationTime(Instant now, Duration duration) { |
| @@ -19,11 +19,12 @@ public JsonAwsWriter(AmazonS3 awsClient) { | |||
|
|
|||
| @Override | |||
| public void writeContent(ContentStorage<String> json, AwsInfo awsInfo) throws AwsContentWritingException { | |||
Collaborator
There was a problem hiding this comment.
interface does not enforce that there is always one element in ContentStorage json,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.