Ensure Client.close() cleans up client context appropriately #643
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
tests
client
Contributor
There was a problem hiding this comment.
Pull Request Overview
The purpose of this PR is to ensure that the client context is cleaned up appropriately when close() is called, addressing issues identified in #635. Key changes include the addition of a new test for handling concurrent tasks in the proxy, refactoring of the client context management in client.py by introducing _connect and _disconnect methods, and the integration of new concurrency primitives.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/server/test_proxy.py | Added a test to verify correct handling of concurrent tasks |
| src/fastmcp/client/client.py | Refactored context management to improve session cleanup and prevent race conditions |
jlowin
added
the
bug
jlowin
changed the title
jordicore
pushed a commit
to jordicore/fastmcp
that referenced
this pull request
Jul 2, 2025
Ensure close() cleans up client context appropriately
This was referenced Oct 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #635 that fixes
Client.close()to manage concurrency properly and also adds a test for Client concurrency