Conversation
This commits allows deployers to override the golang url. It's useful if they have a repository with software, and want to target it immediately. Signed-off-by: Jean-Philippe Evrard <jean-philippe.evrard@rackspace.co.uk>
yogo1212
force-pushed
the
auto_discovery_cont
branch
from
729cd76 to
6c2d4a5
Compare
This will allow the upgrading of versions automatically, without the need of changes in the role. Recently, golang made public the storage bucket where the tar.gz and .sha256 files for releases are published. This commit makes use of this in an automated fashion Signed-off-by: Jean-Philippe Evrard <jean-philippe.evrard@evrard.me>
yogo1212
force-pushed
the
auto_discovery_cont
branch
from
6c2d4a5 to
a94ca34
Compare
|
there's more |
yogo1212
force-pushed
the
auto_discovery_cont
branch
from
9274407 to
5bddce8
Compare
yogo1212
force-pushed
the
auto_discovery_cont
branch
from
5bddce8 to
eb94190
Compare
|
something about those comments in the defaults yml just makes adding hunks impossible.. |
yogo1212
force-pushed
the
auto_discovery_cont
branch
from
1a8b179 to
18dc711
Compare
|
k - i'm done :-p you might want to ask about splitting this PR ;-) |
yogo1212
force-pushed
the
auto_discovery_cont
branch
from
69c2f6d to
c501a7b
Compare
|
is it that bad? 😕 |
|
@jlund are you still active in this repo? |
|
good question @yogo1212 but I haven't seen an answer to my first PR asking for the same thing. What have you done since then? |
|
This series of patch can probably be reduced to 2 or 3 commits, but I generally like them. 👍 . |
|
@evrardjp i've implemented the signature check, "streamlined" vars and defaults, and slightly refactored some of the code. |
evrardjp
left a comment
evrardjp
left a comment
There was a problem hiding this comment.
Can you squash all those commits into one?
| checksum: "{{ go_tarball_checksum }}" | ||
| - block: | ||
| - name: Discover the latest version | ||
| shell: |
There was a problem hiding this comment.
the shell command is on a new line, so it makes sense to me to have >- or | at line 4. But I might be wrong and ansible might be smart there. Just an habit I'd say :)
|
i can squash but i'd rather wait until right before the merge. |
|
@yogo1212 same. But I think it's better if we are working together than having a bazillion roles doing the same thing. :) |
|
thanks for the change :) |
|
i invite you to leave your opinion on how ansible-go should be developed in the future: |
2 participants
cont #28