Updated examples#2
Merged
Merged
Conversation
This reverts commit bb7c3e0.
Updated Examples
Owner
|
Cool! Thank you for the note and for submitting the pull request. I don't have much free time to poke at NES stuff these days but I'm glad this was useful in some small way. I'll merge this back in with the hopes that it'll help anyone else looking at this in the future. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Feel free to ignore this but I was poking at nes code this weekend and your repo was the best to start from. This PR adds stuff like
I've built it on osx as you recommend and also on linux without any real issue.
I'm generally unsure if the code I'm bringing in is newer or older than the existing code but from the additional examples it supports as well as the additional functionality, I'm guessing it's newer.