Draft
Conversation
Now also matches on parry.gg urls
Now also matches on parry.gg urls. Includes commented code that will be uncommented once the parry.gg integration is further along.
Mostly boilerplate with lots of imports, but will be worked on. Just need a starting point.
Services can be created as they're required with _create_service _initialize_grpc_connection was unnecessary, and the channel is now setup in __init__.
Will verify the service is none before creating it, rather than relying on the service being verified as none before it is called.
Errors for: Tournament or Event Not Found Unauthenticated (Incorrect or No API Key)
Likely unnecessary but good to do before I forget.
Need to be added manually into the game's config.json, but this is an issue for later in StreamHelperAssets Examples for ssbm and ssbu respectively if you want it to work in the meantime - "parrygg_game_id": "01920676-416e-7838-b6aa-8d4453256f05" - "parrygg_game_id": "01920676-416e-7b49-a669-7157bd4a6934"
Requested by parry.gg team. Examples are now: "parrygg_game_id": "super-smash-bros-ultimate" "parrygg_game_id": "super-smash-bros-melee"
One last example for a game's config.json: "parrygg_game_slug": "super-smash-bros-melee"
Disable StartGG-specific buttons if StartGG isn't the bracket provider
Could be implemented in future, but for now it's not a focus. Trying to avoid crashes.
Specifically for GetMatches and GetStations
Copied from StartGGDataProvider as it is a very simple function. Could maybe be moved into TournamentDataProvider instead
Actually fix sponsor name Get Completed Matches when Getting a Match Make Score an Int Match StartGG method definitions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Started working on this a few months back, haven't touched it in a little while, but getting back into it now.
As of right now, it supports enough to not crash when a parry.gg tournament is set, this includes:
In order to implement the above, a new setting was added to store the user's parry.gg API key.
Plenty still left to implement and fix though, definitely not ready to use at events as of yet. Additionally, some functionality is not yet supported by parry.gg (Mainly Stations/Streams), and as such cannot be fully implemented until that changes.