ADR-278: ADR-191 ADR-278 1 OOP Pipeline: DVC wiring for intent stages - #218
Merged
jodavis merged 7 commits intoJun 13, 2026
Merged
Conversation
jodavis
commented
Jun 11, 2026
jodavis
enabled auto-merge (squash)
June 12, 2026 22:59
… stage names - Move ml/download_phoneme_dictionary.py to ml/pipeline/download_phoneme_dictionary.py so it lives alongside other pipeline scripts - Add --output-dir argument to the download script instead of hardcoding the path - Prefix all dvc.yaml stage names with intent_NN_ to match the script naming convention - Update dvc.lock to reflect renamed stages and updated cmd Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
jodavis
force-pushed
the
dev/claude/ADR-278-dvc-pipeline
branch
from
June 13, 2026 14:26
220a52d to
7aa11f5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADR-278: Wire intent stages into DVC pipeline
Closes ADR-278.
Summary
Wires the two OOP intent-stage entry-points (
intent_01_generate_phrases.pyandintent_02_compute_vocab.py) into DVC, completing Task 3b of the OOP ML pipeline feature.Changes
ml/params.yamlpipeline.input_phrases_path: scripts/intent_prediction/01_input_phrases.csvml/download_phoneme_dictionary.pycmudict-0.7bfrom CMU Sphinx SVN todata/phoneme_dictionary/cmudict-0.7bml/dvc.yamldownload_phoneme_dictionary,generate_phrases,compute_vocabml/.dvc/configadr-ml-training-dataas the default S3 remote (s3://adr-ml-training-data/dvc)ml/.dvc/.gitignore/tmpand/cacheinside.dvc/ml/.gitignore.dvc/tmp,.dvc/cache, and/data/Key Decisions
.dvc/configand.dvc/.gitignorewritten directly;dvc init --subdircan be run once fromml/if DVC reports missing internals.cmdhardcodes input phrases path: DVC${}interpolation incmdonly works inforeachstages; path is hardcoded incmdand tracked viaparams:so DVC re-runs if the param changes.download_phoneme_dictionary.pywritten from scratch: stdlib-only (urllib.request.urlretrieve); no prior version found in git history.persist: truenot used: Neither intent stage usesModifierStage.Validation
validate-buildandvalidate-testspass — no C# or Python unit test changes.dvc repro(cwdml/) will: download CMU dict → generate phrase variants → compute vocab.