Add devcontainer definition for reproducible Linux dev environment by jodavis-claude · Pull Request #236 · jodavis/AdaptiveRemote

jodavis-claude · 2026-06-23T11:52:06Z

Provides a Docker-based devcontainer so Claude Code remote sessions and
local contributors get a consistent environment with all dependencies
pre-installed.

Base image: mcr.microsoft.com/devcontainers/base:ubuntu-24.04 (vscode
user with passwordless sudo, git, curl pre-installed)
Baked into image: GitHub CLI, .NET 10 SDK, PowerShell, Node.js LTS,
Claude Code CLI, Playwright OS-level Chromium deps, Python ML venv
at /opt/ml-env with numpy/pandas/tensorflow/dvc
~/.claude mounted as named volume (survives container rebuilds; first
Claude Code login is interactive, subsequent starts reuse credentials)
GITHUB_TOKEN forwarded from host environment so gh works without
interactive login
post-create.sh: dotnet restore → dotnet build → playwright.ps1 install
chromium --with-deps (version-matched to Microsoft.Playwright NuGet pin)
ml/requirements.txt added alongside devcontainer so Dockerfile COPY
works from the repo-root build context

Co-Authored-By: Claude Sonnet 4.6 noreply@anthropic.com
Claude-Session: https://claude.ai/code/session_019jmGA95hGTRu4aZ4yL45NL

Provides a Docker-based devcontainer so Claude Code remote sessions and local contributors get a consistent environment with all dependencies pre-installed. - Base image: mcr.microsoft.com/devcontainers/base:ubuntu-24.04 (vscode user with passwordless sudo, git, curl pre-installed) - Baked into image: GitHub CLI, .NET 10 SDK, PowerShell, Node.js LTS, Claude Code CLI, Playwright OS-level Chromium deps, Python ML venv at /opt/ml-env with numpy/pandas/tensorflow/dvc - ~/.claude mounted as named volume (survives container rebuilds; first Claude Code login is interactive, subsequent starts reuse credentials) - GITHUB_TOKEN forwarded from host environment so gh works without interactive login - post-create.sh: dotnet restore → dotnet build → playwright.ps1 install chromium --with-deps (version-matched to Microsoft.Playwright NuGet pin) - ml/requirements.txt added alongside devcontainer so Dockerfile COPY works from the repo-root build context Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019jmGA95hGTRu4aZ4yL45NL

Builds the Docker image on every push/PR that touches devcontainer files or ml/requirements.txt, then runs a smoke test inside the built container to verify .NET, gh, Node.js, Python, and the ML venv packages are all present and importable. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019jmGA95hGTRu4aZ4yL45NL

github-actions · 2026-06-23T11:56:55Z

Test Results

401 tests ±0 401 ✅ ±0 2m 34s ⏱️ +29s
5 suites ±0 0 💤 ±0
5 files ±0 0 ❌ ±0

Results for commit a246452. ± Comparison against base commit d2636b6.

This pull request removes 3 and adds 2 tests. Note that renamed tests count towards both.

,False)
AdaptiveRemote.Services.ProgrammaticSettings.PersistSettingsTests ‑ PersistSettings_Set_ValidatesKeyNameAsync (Hello
AdaptiveRemote.Services.ProgrammaticSettings.PersistSettingsTests ‑ PersistSettings_Set_ValidatesValueAsync (Invalid

AdaptiveRemote.Services.ProgrammaticSettings.PersistSettingsTests ‑ PersistSettings_Set_ValidatesKeyNameAsync (Hello
,False)
AdaptiveRemote.Services.ProgrammaticSettings.PersistSettingsTests ‑ PersistSettings_Set_ValidatesValueAsync (Invalid
,False)

♻️ This comment has been updated with latest results.

Copilot

Pull request overview

Adds a Docker-based devcontainer definition (plus CI validation) to provide a consistent Linux development environment for contributors/remote sessions, including preinstalled .NET/Node/Python tooling and a post-create bootstrap script.

Changes:

Added .devcontainer/ definition (Dockerfile + devcontainer.json) and a post-create.sh script to restore/build and install Playwright Chromium.
Added a GitHub Actions workflow to build the devcontainer image and run a basic smoke test for installed tooling.
Added ml/requirements.txt to support baking ML Python dependencies into the devcontainer image.

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.

Show a summary per file

File	Description
`ml/requirements.txt`	Introduces pip requirements used during devcontainer image build.
`.github/workflows/devcontainer-build.yml`	Adds CI job to build the devcontainer image and smoke test key tools/packages.
`.devcontainer/post-create.sh`	Adds post-create bootstrap steps (restore/build + Playwright browser install).
`.devcontainer/Dockerfile`	Defines the devcontainer image and preinstalls developer dependencies.
`.devcontainer/devcontainer.json`	Configures devcontainer build, mounts, env vars, and editor settings/extensions.

On Debian/Ubuntu, python3-venv is a separate package from python3 and must be explicitly installed before python3 -m venv will work. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019jmGA95hGTRu4aZ4yL45NL

Copilot

Pull request overview

Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.

- Dockerfile: replace curl|bash NodeSource install with explicit GPG keyring + pinned node_24.x repo for auditability and reproducibility - devcontainer.json: forward GH_TOKEN alongside GITHUB_TOKEN (gh CLI checks both env vars depending on how the host is configured) - post-create.sh: export ~/.dotnet/tools to PATH in the fallback branch before calling playwright, since global tool installs land there and it is not on PATH by default; fix quality gate script names to include the .sh extension - ml/requirements.txt: pin to versions validated by the CI build (numpy 2.5.0, pandas 3.0.3, tensorflow 2.21.0, dvc 3.67.1) Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019jmGA95hGTRu4aZ4yL45NL

…ials Docker initialises a named volume from the image's directory at the mount point. If the directory doesn't exist in the image, Docker creates a root-owned entry and the vscode user cannot write to it — causing the 'login succeeds in browser but shows as not logged in' symptom. Creating ~/.claude as the vscode user in the Dockerfile ensures the volume is initialised with UID 1000 ownership on first use. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019jmGA95hGTRu4aZ4yL45NL

…racking, code style, and documentation standards.

…istry github.repository expands to jodavis/AdaptiveRemote (uppercase A) which Docker rejects — registry names must be all lowercase. Add a step that pipes the repository name through tr to produce the lowercase image name, then reference it via step output in imageName and cacheFrom. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019jmGA95hGTRu4aZ4yL45NL

Was pointing at /home/vscode/.claude/settings.json (the volume target, same as CLAUDE_SETTINGS). Should point at /home/vscode/.claude-defaults/ settings.json where the Dockerfile bakes the template. In CI the named volume is always fresh so the source never exists and cp fails. Locally this is masked because returning developers already have settings in the persistent volume and the if-block is skipped. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

validate.sh calls validate-build.sh and validate-tests.sh directly (no bash prefix), so they must be executable. Without the execute bit the devcontainer CI run fails with exit code 126 (permission denied) when validate.sh reaches line 20. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

claude added 2 commits June 23, 2026 07:55

jodavis requested a review from Copilot June 23, 2026 11:53

Copilot started reviewing on behalf of jodavis June 23, 2026 11:53 View session

Copilot AI reviewed Jun 23, 2026

View reviewed changes

Comment thread .devcontainer/post-create.sh

Comment thread .devcontainer/post-create.sh Outdated

Comment thread ml/requirements.txt Outdated

jodavis requested review from Copilot and jodavis June 23, 2026 12:08

Copilot started reviewing on behalf of jodavis June 23, 2026 12:08 View session

Copilot AI reviewed Jun 23, 2026

View reviewed changes

Comment thread .devcontainer/post-create.sh

Comment thread .devcontainer/post-create.sh Outdated

Comment thread .devcontainer/devcontainer.json

Comment thread ml/requirements.txt Outdated

Comment thread .devcontainer/Dockerfile

jodavis approved these changes Jun 23, 2026

View reviewed changes

jodavis enabled auto-merge (squash) June 23, 2026 12:20

jodavis disabled auto-merge June 23, 2026 12:20

jodavis enabled auto-merge (rebase) June 23, 2026 12:20

jodavis disabled auto-merge June 23, 2026 12:20

claude and others added 8 commits June 23, 2026 14:57

Configure container with default permissions settings

9b7853f

Add skills to define agent behavior specific to this project's work t…

26b7e78

…racking, code style, and documentation standards.

CI validation of devcontainer with conditional execution

2cc90f3

Minor updates to skill definitions

a246452

jodavis approved these changes Jun 26, 2026

View reviewed changes

jodavis merged commit 30d2cdb into main Jun 26, 2026
4 checks passed

jodavis deleted the claude/devcontainer-setup-dv0qmu branch June 26, 2026 22:45

jodavis-claude mentioned this pull request Jun 26, 2026

Merge main into feature/ADR-191-oop-ml-pipeline #237

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add devcontainer definition for reproducible Linux dev environment - #236

Add devcontainer definition for reproducible Linux dev environment#236
jodavis merged 12 commits into
mainfrom
claude/devcontainer-setup-dv0qmu

jodavis-claude commented Jun 23, 2026

Uh oh!

github-actions Bot commented Jun 23, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

jodavis-claude commented Jun 23, 2026

Uh oh!

github-actions Bot commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Test Results

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

github-actions Bot commented Jun 23, 2026 •

edited

Loading