Allow automated GitHub PR review posting without prompting - #249
Merged
Conversation
The dev-team review/sign-off pipeline was hard-stopping mid-flight: posting a review to a PR requires either gh api or the github MCP server's pull_request_review_write/add_comment_to_pending_review/ add_reply_to_pull_request_comment calls, none of which were pre-approved, so review posting silently failed on every PR and a peer-agent workaround attempt correctly got refused as permission laundering. Scoped narrowly to review-posting actions only (not update_pull_request, which covers draft/reviewer-request and is a separate authorization). Also allowlists mcp__plugin_github_github__* alongside mcp__github__* since the dev-team plugin's agent definitions reference the former name while this project's .mcp config registers the server as plain "github" - only one of the two is likely to actually resolve, but the mismatch itself is a plugin-side naming issue out of scope here. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NhMgWJeN4ytrcZdaWZYgqY
jodavis-claude
enabled auto-merge (rebase)
July 28, 2026 01:29
Test Results401 tests ±0 401 ✅ ±0 2m 0s ⏱️ -4s Results for commit f5f3ec2. ± Comparison against base commit e720a36. This pull request removes 3 and adds 2 tests. Note that renamed tests count towards both. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gh api/github-MCP calls that weren't pre-approved, so the reviewer agent's Step 7 (post the review) always hit a permission denial.allowrules for review-posting only (gh api .../reviews,gh pr review,pull_request_review_write,add_comment_to_pending_review,add_reply_to_pull_request_comment) — deliberately excludesupdate_pull_request(draft/reviewer-request), which is separate scope.mcp__plugin_github_github__*tools, but this project's.claude/settings.jsonregisters the server as plaingithub(mcp__github__*). Allowlisted both names since only one will actually resolve; the mismatch itself is a plugin-side issue, out of scope for this fix.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01NhMgWJeN4ytrcZdaWZYgqY