Wire up REVIEW_ASSIGNEE_EMAIL for hand-off - #250
Open
jodavis-claude wants to merge 1 commit into
Open
Conversation
final-sign-off and work-with-pr reference \$REVIEW_ASSIGNEE_EMAIL to look up the human reviewer's Jira/GitHub identity at hand-off, but it was never set anywhere, so every task's PR hand-off stalled on the reviewer-assignment step (hit on both ADR-338 and ADR-339). Note: GitHub rejects a review request where reviewer == PR author. These PRs are currently authored under the same jodavis account this resolves to, so the GitHub review-request half of final-sign-off's step 2 is expected to no-op/skip for now (Jira assignment still applies) until PR authorship moves to a separate identity. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NhMgWJeN4ytrcZdaWZYgqY
jodavis-claude
enabled auto-merge (rebase)
July 28, 2026 01:37
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
final-sign-offandwork-with-prreference$REVIEW_ASSIGNEE_EMAILto look up the human reviewer's Jira/GitHub identity at hand-off, but it was never set anywhere — every task's PR hand-off stalled on the reviewer-assignment step (hit on both ADR-338 and ADR-339).jodavis-claudeaccount (confirmed via a livegh apireview-post — see PR ADR-338: Wire mypy --strict static analysis into ml/ build #246's review), so the GitHub review-request step should NOT hit a self-review conflict as originally assumed.Test plan
🤖 Generated with Claude Code
https://claude.ai/code/session_01NhMgWJeN4ytrcZdaWZYgqY