ADR-365: Update stale handoff prose in workflow-orchestrate plan assets - #100
ADR-365: Update stale handoff prose in workflow-orchestrate plan assets#100jodavis-claude wants to merge 2 commits into
Conversation
build-and-test: Python test resultsStatus: ✅ Passed Test log |
jodavis-claude
left a comment
jodavis-claude
left a comment
There was a problem hiding this comment.
Reviewed against the ADR-365 task brief and exit criteria.
Exit criteria check:
implement-task-plan.md's post-diagram prose no longer claimsfinal-sign-offitself converts the PR to ready, assigns the Jira issue, requests review, and comments — now correctly describes theafter-hand-off-instruction-driven split. Met.fix-issue-plan.md's equivalent prose updated identically. Met.- Neither file's mermaid diagram or state transition table changed — confirmed via diff (only the prose paragraph after each diagram was touched). Met.
Consistency check: Cross-referenced against plugins/dev-team/skills/get-project-configuration/assets/default-config.yaml's after-hand-off defaults (promote, request-review, assign-work-item — no comment step) already landed via ADR-360 on this PR's base branch. The new prose's terminology and behavior description line up with that config, and correctly omit the old "Jira comment" clause per the brief. final-sign-off/SKILL.md itself hasn't been trimmed yet (ADR-363 not yet merged into this base branch) — that's a pre-existing, already-flagged sequencing gap for the epic, not something this prose-only PR needs to resolve.
No Priority 1-4 issues found (this is a documentation-prose-only change with no code, so correctness/security/performance dimensions don't apply).
Minor style nit (non-blocking): in both files, "converting the PR to ready for review, requesting the human reviewer's GitHub review, and assigning the work item to them is performed afterward" — three coordinated gerund-phrase subjects joined by "and" conventionally take a plural verb ("are performed"). Feel free to leave as-is or fix at your discretion.
Approving.
final-sign-off no longer itself converts the PR to ready, assigns the work item, and requests review — that work now happens via this event's configured after-hand-off instructions. Updated the prose in both implement-task-plan.md and fix-issue-plan.md to describe the new instruction-driven split; mermaid diagrams and transition tables are unchanged.
8b9af93 to
9b700eb
Compare
| The `handoff` state runs `final-sign-off` once a PR has been approved — either directly | ||
| out of `reviewing` on a clean first pass, or out of `signoff` after a `fixing-pr` cycle. | ||
| It converts the PR from draft to ready for review, assigns the Jira issue to the human | ||
| reviewer, requests their GitHub review, and adds a Jira comment noting the hand-off. | ||
| `final-sign-off` itself only reports that the hand-off point was reached; converting the PR | ||
| to ready for review, requesting the human reviewer's GitHub review, and assigning the work | ||
| item to them is performed afterward by this event's configured `after-hand-off` instructions. |
There was a problem hiding this comment.
This won't be accurate anymore. handoff is being removed, and handoff activities are now after-signoff-success events. However, we should only mention those activities as examples, because they won't be in the default set later.
| The `handoff` state runs `final-sign-off` once a PR has been approved — either directly | ||
| out of `reviewing` on a clean first pass, or out of `signoff` after a `fixing-pr` cycle. | ||
| It converts the PR from draft to ready for review, assigns the Jira issue to the human | ||
| reviewer, requests their GitHub review, and adds a Jira comment noting the hand-off. | ||
| `final-sign-off` itself only reports that the hand-off point was reached; converting the PR | ||
| to ready for review, requesting the human reviewer's GitHub review, and assigning the work | ||
| item to them is performed afterward by this event's configured `after-hand-off` instructions. |
|
There are no changes to make here, the prose is already being updated in PR #99 |
3 participants
Work item: ADR-365 — the
handoff-state prose inworkflow-orchestrate's two plan asset files (implement-task-plan.md,fix-issue-plan.md) incorrectly claimedfinal-sign-offitself converts the PR to ready, assigns the Jira issue, requests review, and comments. That responsibility split moved to the newafter-hand-offinstruction mechanism (ADR-363/ADR-361/ADR-360), and this task updates the documentation to match.Changes:
plugins/dev-team/skills/workflow-orchestrate/assets/implement-task-plan.md— rewrote the post-mermaid-diagram paragraph describing thehandoffstate:final-sign-offnow described as only reporting hand-off readiness, with PR-ready/review-request/assignment work performed afterward by the event's configuredafter-hand-offinstructions.plugins/dev-team/skills/workflow-orchestrate/assets/fix-issue-plan.md— identical rewrite applied to the equivalent paragraph for consistency between the two plan assets.Design decisions:
after-hand-offinstructions (promote,request-review,assign-work-item) don't include a comment step.mainand does not include ADR-363's code changes (not yet merged intofeature/ADR-337-config); since the edit is prose-only and doesn't depend on that code being present, it proceeded without pulling those commits in.Testing completed:
No unit or E2E tests apply — this is a documentation-prose-only change with no classified components in scope. Verified via manual review that the rewritten prose accurately reflects the new
handoffsequence described in_spec_WorkflowEventHooks.mdand the already-implementedfinal-sign-off/work-with-pr/run-event-hooksskills.