ADR-256: Remove authenticated connector tools from sub-agents; add 8-milestone scrum master table

[jodavis-claude]

Work item

ADR-256 — Remove Jira MCP tools from the Developer sub-agent, update the Reviewer output format to reflect the thread-based schema, and add the full 8-milestone scrum master milestone table (with sidecar file mechanics) to dev-team.md so the top-level session owns all GitHub and Jira operations.

Changes

• plugins/dev-team/agents/developer.md — Removed all five Jira MCP tool entries (mcp__jira__atlassianUserInfo, mcp__jira__getTransitionsForJiraIssue, mcp__jira__transitionJiraIssue, mcp__jira__editJiraIssue, mcp__jira__addCommentToJiraIssue) from the tools: list; Developer now relies solely on Bash/git for its operations.
• plugins/dev-team/agents/reviewer.md — Updated role description body and replaced the output format section: old {"status": "...", "pr_url": "..."} replaced with the full {body, threads[], status} schema; documented that pr_url moves to the scrum master sidecar file.
• plugins/dev-team/commands/dev-team.md — Added Step 6 (244 lines) covering: sidecar file structure (.claude/logs/dev-team/<work-item-id>-threads.json) and load/write semantics; context file section extraction via sentinel comments; Jira idempotency guard; thread-posting logic (reply-existing vs. create-new); and all 8 milestone entries with full action descriptions.

Design decisions

• mcp__github__help unavailable — fell back to gh CLI. The spec called for discovering exact MCP method names for reply-to-thread and resolve-thread at implementation time. The plugin:github:github MCP server never became available in this session. Used gh api .../pulls/comments/<id>/replies (for githubCommentId) and gh api graphql resolveReviewThread (for githubThreadId) — the same patterns already established in reviewer-review.md and reviewer-sign-off.md.
• Reviewer frontmatter description not changed. The brief flagged updating "Creates GitHub PRs and posts structured review comments" as an ambiguity (scope unclear for ADR-256). Resolved conservatively — no change.
• Step 6 is additive. Steps 1–5 are untouched; Step 6 describes concurrent scrum master behavior triggered by [DEV-TEAM] markers while Step 4's pipeline runs.

[jodavis-claude]

ADR-256 First-Pass Review

Three issues require changes: one exit-criterion gap (P1) and two correctness bugs in dev_team.py (P2). One documentation note (P4) on reviewer.md frontmatter.

Exit criteria status

• developer.md: all 5 Jira MCP tools removed
• reviewer.md: output format updated to {body, threads[], status}
• dev-team.md: all 8 milestones present with sidecar read/write logic; [DEV-TEAM] PR details ready absent (guard satisfied)
• GitHub MCP method names for reply/resolve: implementation uses gh api REST/GraphQL instead of MCP methods (see inline comment)

[jodavis-claude]

Sign-off review: all three prior threads addressed satisfactorily. (1) Exit criterion #4 met — mcp__plugin_github_github__add_reply_to_pull_request_comment discovered and used in dev-team.md; resolve-thread correctly falls back to gh api graphql resolveReviewThread since no MCP equivalent exists. (2) review_notes empty-string bug fixed — ctx.signoff_notes or join(failures) preserves sign-off body when only failure is unresolved threads. (3) ctx.save() ordering in FixPrStep corrected — iteration count and work summaries now persisted before save. No new P1–P4 issues found in modified files. Approving.