Skip to content

Some proposed updates#17

Merged
joefazz merged 8 commits into
joefazz:masterfrom
brody2consult:some-updates
Apr 9, 2019
Merged

Some proposed updates#17
joefazz merged 8 commits into
joefazz:masterfrom
brody2consult:some-updates

Conversation

@brody2consult

@brody2consult brody2consult commented Apr 8, 2019

Copy link
Copy Markdown
  • alphabetical devDependencies in package.json
  • drop support for non-functional test scripts (and remove from the Tasks list)
  • drop support for non-functional eject-web task (this commit closes the issue that I raised in eject-web failure #16)
  • add functional yarn start-expo script (and mark existing start-native script as "not supported")
  • Expo 28 update (note that I had trouble with newer versions of Expo, as explained by expo update #14 (comment))
  • ignore .*.swp (maybe this should be left to the user's global git config?)
  • require logo image in the beginning of src/App.js (a little cleaner, maybe a little more efficient)
  • Remove StatusBar usage not needed (this was causing an issue with using react-primitives)

I would be happy to raise some or all of these updates in separate PRs if needed.

I will likely continue with a fresh new template from expo init, raising this PR for the benefit of existing users.

Christopher J. Brody added 5 commits April 8, 2019 12:54
and mark existing start-native script as "not supported"
Note that expo 27 packages (`expo` and `react-native`) were removed
first in order to avoid old package versions in yarn.lock.

@joefazz joefazz left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing all this I really appreciate it!

@joefazz joefazz merged commit 5b4afdb into joefazz:master Apr 9, 2019
@brody2consult brody2consult deleted the some-updates branch April 9, 2019 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants