Some proposed updates#17
Merged
Merged
Conversation
added 5 commits
April 8, 2019 12:54
and mark existing start-native script as "not supported"
Note that expo 27 packages (`expo` and `react-native`) were removed first in order to avoid old package versions in yarn.lock.
e77185c to
43ab256
Compare
joefazz
approved these changes
Apr 9, 2019
joefazz
left a comment
Owner
There was a problem hiding this comment.
Thanks for doing all this I really appreciate it!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devDependenciesinpackage.jsoneject-webtask (this commit closes the issue that I raised in eject-web failure #16)yarn start-exposcript (and mark existing start-native script as "not supported")src/App.js(a little cleaner, maybe a little more efficient)react-primitives)I would be happy to raise some or all of these updates in separate PRs if needed.
I will likely continue with a fresh new template from
expo init, raising this PR for the benefit of existing users.