Skip to content

Support Go 1.17, remove Go 1.14#29

Merged
joeig merged 1 commit intomasterfrom
go-1.17
Oct 14, 2021
Merged

Support Go 1.17, remove Go 1.14#29
joeig merged 1 commit intomasterfrom
go-1.17

Conversation

@joeig
Copy link
Owner

@joeig joeig commented Oct 14, 2021

  • Does your submission pass all tests against mocks? make test
  • Does your submission pass all tests against a real instance running PowerDNS Authoritative Server 4.1, 4.2 and 4.3? docker-compose -f docker-compose-v4.3.yml up && make test-without-mocks
  • Do your tests meet or exceed the coverage results of the master branch? make coverage && go tool cover -html=c.out
  • Does your submission pass the format guidelines? make check-fmt

Furthermore, the pipeline performs additional checks against your submission:

  • Does your submission comply with common best practices? golangci-lint run && staticcheck ./...

@joeig joeig self-assigned this Oct 14, 2021
@joeig joeig merged commit aa8dcfc into master Oct 14, 2021
@joeig joeig deleted the go-1.17 branch October 14, 2021 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant