ClassNotFoundException when attempting to use a custom annotator from a project dependency

[Cuneytt]

Trying to generate POJOs from JSON examples (not schemas) using the following maven configuration:

                <groupId>org.jsonschema2pojo</groupId>
                <artifactId>jsonschema2pojo-maven-plugin</artifactId>
                <version>0.4.5</version>
                <configuration>
                    <sourceDirectory>src/main/resources/json</sourceDirectory>
                    <outputDirectory>${project.build.sourceDirectory}</outputDirectory>
                    <targetPackage>com.test.applications.service.model</targetPackage>
                    <sourceType>JSON</sourceType>
                    <generateBuilders>true</generateBuilders>
                    <includeHashcodeAndEquals>false</includeHashcodeAndEquals>
                    <annotationStyle>NONE</annotationStyle>
               </configuration>

this generates POJOs as expected without any annotations but still generates the addtionalProperties:

private Map<String, Object> additionalProperties = new HashMap<String, Object>();

I know disabling this is possible through schema declaration through "additionalProperties": false
but in my case I generate from json examples.

I tried to use a custom Annotator that will override the AbstractAnnotator and run it through maven:

public class CustomNoopAnnotator extends AbstractAnnotator{
    @Override
    public boolean isAdditionalPropertiesSupported() {
        return false;
    }
}

and additional config in maven:

<customAnnotator>com.test.application.generator.CustomNoopAnnotator</customAnnotator>

this class is another module and the module I am trying to generate POJOs from has a dependency to this module.

I get java.lang.ClassNotFound exception with this setup.

I'd appreciate any feedback as to how to disable additionalProperties HashMap from being generated using JSON source type.

[joelittlejohn]

I think your CustomNoopAnnotator approach is a good one. We just need to work out why this class can't be found.

I think we could consider adding a config property for this, to basically disable additional property support (even for the annotators that can support it).

[Cuneytt]

Thanks for the quick response.

Going through Jsonschema2PojoMoja.java, addProjectDependenciesToClasspath; (line 402) is
after new AnnotatorFactory().getAnnotator(getCustomAnnotator()); (line 376)
can it be the reason why the custom annotator is not picked up?

[joelittlejohn]

Yes, that sounds like the cause. I can take a look at this tonight. Alternatively if you have a chance (and you are able to build a snapshot to test this) then you could submit a PR to fix.

[Cuneytt]

Thank you

[sundhar-perumal]

I am using 0.4.12v of jsonschema but still i face the same problem.

Simple,

1. I had a maven project with jsonschema 0.4.12 dependancy.
2. I created a custom annotator in the same maevn project and configured in maven build plugin
3. When i executed the maven build, I still get NoClassDefFoundError..

Looks like Jsonschema2PojoMojo when creating new URLCLassloader it doesnt copy the parent loaded classes.

Suggest what could be the solution

[joelittlejohn]

Did you add the module that contains the custom annotator as a dependency on the plugin? (<dependencies> inside <plugin>)

[sundhar-perumal]

Hi, yes adding the annotator module inside solved the problem.., Thanks for the suggesstion.

But why would a plugin require to define all its dependency inside it. Ideally, it should pick any other dependency from global dependecies list.