Allow empty package names#348
Merged
joelittlejohn merged 2 commits intojoelittlejohn:masterfrom May 7, 2015
Merged
Conversation
joelittlejohn
added a commit
that referenced
this pull request
May 7, 2015
Allow empty package names
Owner
|
👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR corrects an issue where the
targetPackageis empty and source files were being generated with apackage .;statement.This update has the following known limitation: If the source directory contains a directory that is a java keyword, like
/default, then the generated source will be invalid. Not sure if handling key words should be part of this PR or another.