fix(themes): fix WCAG AA contrast failures in 3 built-in themes#115
Merged
Conversation
- classic: #4c6fff → #4267ff (4.17→4.55:1 on #0d1117) - islands-dark: #548af7 → #286cf5 (3.30→4.61:1 on #0f1923) - islands-light: #3574f0 → #2c6def (4.27→4.60:1 on #f5f7fa)
Owner
|
@copilot resolve the merge conflicts in this pull request |
Owner
|
Thank you very much for this! <3 |
# Conflicts: # src/styles.css
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three built-in themes had accent/border-focus colors that failed the WCAG AA minimum contrast ratio of 4.5:1 against their respective backgrounds. This caused accessibility issues for users who rely on sufficient color contrast (e.g. low-vision users, or users in bright environments).
Changes
--accent,--border-focus#4c6fff#4267ff--accent,--border-focus#548af7#286cf5--accent,--border-focus#3574f0#2c6defAll three now meet WCAG AA (≥ 4.5:1). The hue shifts are minimal and the visual appearance of each theme is essentially unchanged.
What these colors affect
Testing
Switch between the classic, islands-dark, and islands-light themes in settings and verify buttons, focused inputs, and selected tasks look correct. Contrast ratios can be confirmed with the browser/DevTools accessibility inspector.