Skip to content

Receive addresses: handle address generation and unlock failures #108

Description

@johnny9

Gap

Receive address generation can fail silently, and WalletQmlModel::newAddress() dereferences dest.value() without checking the result. The receive page ignores commitPaymentRequest() failure and shows no recovery path.

Work

Check address-generation results, propagate localized errors to QML, handle locked/encrypted wallet unlock when needed, and keep the UI from showing a created request when no address was created.

Code References

  • qml/models/walletqmlmodel.cpp:507
  • qml/models/walletqmlmodel.cpp:616
  • qml/pages/wallet/RequestPayment.qml:296
  • bitcoin/src/qt/receivecoinsdialog.cpp:173

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingv1.0Required or tracked for v1.0 releasewallet

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions