Skip to content

External signer wallet settings: fix key scheme and password actions #131

Description

@johnny9

Gap

External signer wallets are private-key-disabled, so QML currently labels them as watch-only before considering hasExternalSigner(). Wallet settings also exposes password setup based only on encryption state, even though Qt suppresses encryption/passphrase actions for no-private-key wallets.

Work

Show external signer wallets as external signer wallets, not generic watch-only wallets, and hide or disable wallet password actions for no-private-key/external-signer wallets. Preserve correct behavior for ordinary encrypted wallets.

Code References

  • qml/models/walletqmlmodel.cpp:480
  • qml/pages/wallet/WalletSettings.qml:223
  • qml/pages/wallet/WalletSettings.qml:269
  • qml/pages/wallet/WalletPasswordSettings.qml:180
  • bitcoin/src/qt/walletmodel.cpp:307
  • bitcoin/src/qt/bitcoingui.cpp:1422

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingv1.0Required or tracked for v1.0 releasewallet

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions