Skip to content

External signer wallet creation: preserve usable signer wallet names #132

Description

@johnny9

Gap

QML sanitizes the signer name, truncates it to 20 characters, and only accepts [a-zA-Z0-9_]. Qt uses the signer display name directly and only requires a non-empty wallet name.

Work

Relax external signer wallet name handling to match the app's wallet-name rules, avoid unnecessary truncation, and preserve common signer labels with spaces or hyphens when they are valid wallet names.

Code References

  • qml/walletqmlcontroller.cpp:1065
  • qml/pages/wallet/CreateExternalWallet.qml:87
  • bitcoin/src/qt/createwalletdialog.cpp:113
  • bitcoin/src/qt/createwalletdialog.cpp:24

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requestv1.0Required or tracked for v1.0 releasewallet

    Projects

    Milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions