feat: randomize mandatory fee config values#66
Merged
Conversation
This was referenced Oct 4, 2022
openoms
approved these changes
Oct 5, 2022
openoms
left a comment
openoms
left a comment
There was a problem hiding this comment.
utACK
In view of the Telegram conversation around here: https://t.me/JoinMarketWebUI/4554 I still think this approach makes the most sense.
dergigi
approved these changes
Oct 6, 2022
Contributor
dergigi
left a comment
dergigi
left a comment
There was a problem hiding this comment.
ACK ✅
Tested joinmarket-webui/jam#533 thoroughly and ran a diff on the changes in this PR to make sure there is no typo when compared to the regtest changes.
Looks good, let's merge this 🚀
This was referenced Oct 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #65.
Randomizes
max_cj_fee_absandmax_cj_fee_relif not provided.max_cj_fee_absbetween 5k - 10k satsmax_cj_fee_relto 0.01%, 0.02% or 0.03%Approach is taken from RaspiBlitz PR for Jam: https://github.com/rootzoll/raspiblitz/blob/fe2619a8e60d7277192e1e01231721a26d5ca705/home.admin/config.scripts/bonus.jam.sh#L218-L220
Special thanks to @openoms!