-
Notifications
You must be signed in to change notification settings - Fork 85
Open
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomersv2Related to the redesigned v2 releaseRelated to the redesigned v2 release
Description
right now createBrowserRouter() is being called inside the App component body, which means a new router instance gets created on every render.
since App re-renders on state, context, and translation changes, this causes the router to be recreated repeatedly. react router expects the router instance to be stable, and recreating it can reset internal navigation state, interrupt pending fetchers, and potentially cause subtle routing bugs.
the router should be memoized with the correct dependencies or refactored so it is created once and remains stable across renders.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workinggood first issueGood for newcomersGood for newcomersv2Related to the redesigned v2 releaseRelated to the redesigned v2 release