Fix @SecondTuesdayOfMonth and change logic for pulling rollups#11
Conversation
Fixed @SecondTuesdayOfMonth and change logic for pulling the current and last rollups.
|
This is the corrected pull request. |
|
I'm not really sure why I was having issues with the second Tuesday query but today it's working with the original version. So I guess you can take that with a grain of salt. I still however think the other part of the changes are beneficial as it makes the compliance percentages more accurate based on the time of month and they do not stop working on the first of the month before patch Tuesday. |
|
Hi @Madj42 thank you for your contribution. I haven't had time to look into it yet but will do asap. |
|
No problem. Thank you so much for the awesome report. I love using this
and promoting this for our techs to troubleshoot issues.
…On Tue, Apr 5, 2022, 2:10 PM Jonas Ohmsen ***@***.***> wrote:
Hi @Madj42 <https://github.com/Madj42> thank you for your contribution. I
haven't had time to look into it yet but will do asap.
Best regards
Jonas
—
Reply to this email directly, view it on GitHub
<#11 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AE34CSMZIYBUUKZX73CMSW3VDSF2JANCNFSM5PYGH3QA>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
jonasatgit
left a comment
jonasatgit
left a comment
There was a problem hiding this comment.
Thank you for your contribution. Highly appreciated.
I will update the whole solution in the next couple of days to introduce some more changes and will update the blog article to reflect that.
Best regards
Jonas
2 participants
Fixed @SecondTuesdayOfMonth and change logic for pulling the current and last rollups.