Replace Git graph panel with dialog - #77
Merged
Merged
Conversation
TobTheRock
reviewed
Jul 31, 2025
Collaborator
|
All in all I adore the new design <3 |
jonasehrlich
force-pushed
the
je/revamp-git-view
branch
from
July 31, 2025 07:56
15b5340 to
fb69ecf
Compare
jonasehrlich
changed the title
Using a separate Dialog for the Git Graph and diffs provides a cleaner layout for the graph and diffs. This change also removes the Git graph sliding panel and the GitDiffView.
Divs cannot be nested inside paragraphs (which the DialogDescription is). Also as there is no description `aria-describedby` needs to be explicitly set to `undefined`.
jonasehrlich
force-pushed
the
je/revamp-git-view
branch
from
July 31, 2025 13:22
e8bfc21 to
fa1e11e
Compare
jonasehrlich
changed the title
TobTheRock
approved these changes
Jul 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using a separate Dialog for the Git Graph and diffs provides a cleaner layout for the graph and diffs.
This change also removes the Git graph sliding panel and the
GitDiffView.See the current setup in this video:
Screen.Recording.2025-07-30.at.23.00.57.mp4
This approach should also simplify #6 by showing the commit diff as part of the
CommitDetailscomponentIf there are any UI improvements you can think of, please let me know. This example is with over 50 commits included in the diff, but still, one of the biggest problems I see is the performance of the diff rendering. I'll investigate if this can be done in a lazy manner.
Closes #80