Extract test vectors into separate JSON files#33
Merged
Conversation
robot-dreams
force-pushed
the
json-vectors
branch
from
d14b740 to
fa866b5
Compare
jonasnick
reviewed
Jul 14, 2022
Owner
jonasnick
left a comment
jonasnick
left a comment
There was a problem hiding this comment.
That's a much better presentation of the test vectors. Concept ACK.
Can you also add an entry for the ChangeLog?
robot-dreams
force-pushed
the
json-vectors
branch
4 times, most recently
from
67a7cbf to
1b3da06
Compare
Collaborator
Author
|
This still depends on #24 so shouldn't be merged until that one is. |
Collaborator
real-or-random
left a comment
real-or-random
left a comment
There was a problem hiding this comment.
Concept ACK
This is really much nicer for other implementations.
robot-dreams
force-pushed
the
json-vectors
branch
from
7a3daa2 to
1bb5e9e
Compare
robot-dreams
commented
Jul 29, 2022
robot-dreams
force-pushed
the
json-vectors
branch
from
1bb5e9e to
40ad08b
Compare
robot-dreams
force-pushed
the
json-vectors
branch
from
40ad08b to
d005bb2
Compare
real-or-random
approved these changes
Aug 10, 2022
Collaborator
real-or-random
left a comment
real-or-random
left a comment
There was a problem hiding this comment.
Ok, this is looks nice now. I tested it by playing around with values in the JSON and seeing if the tests catch it.
ACK d005bb2
This helped me in testing, feel free to pick:
real-or-random@70ce59f
ACK 70ce59f
jonasnick
reviewed
Aug 10, 2022
bip-musig2/reference.py
Outdated
Comment on lines
+641
to
+643
| expected_errors = [ | ||
| (InvalidContributionError, lambda e: e.signer == 1) | ||
| ] |
Collaborator
Author
There was a problem hiding this comment.
Thanks for catching!
robot-dreams
force-pushed
the
json-vectors
branch
from
d005bb2 to
8654461
Compare
Owner
|
ACK 8654461 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a re-do of #10 , now that @jonasnick added a bunch of changes and corresponding test cases
It depends on #24, so I'll rebase once that one is merged