Simplify bst.py rotation algorithms#57
Merged
Merged
Conversation
Simplify the bst left and right rotation methods Remove the if block in the _rotate_right and _rotate_left methods from bst.py that validate the parent node of the pivot, as well as the code that updates the pivot's parent at the end of _rotate_right and _rotate_left. The pivot's parent does not change throughout the rotation of the tree. Get rid of the lines that update the parent of the pivot node because the parent of the pivot stays constant in _rotate_left and _rotate_right. Lines 278, 279, 295, 296 can be deleted without altering the functionality of the rotation algorithms and gets rid of the unneeded code that updates the parent of the pivot node. In addition, lines 283 and 300 also unnecessarily update the parent of the pivot node. This can be removed without changing the functionality of _rotate_left and _rotate_right. The parent of the pivot node does not change in _rotate_right or _rotate_left. Delete code that updates the parent of pivot.
Owner
|
Great. Nice work! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplify the bst left and right rotation methods
Remove the if block in the _rotate_right and _rotate_left methods from
bst.py that validate the parent node of the pivot, as well as the code
that updates the pivot's parent at the end of _rotate_right and
_rotate_left.
The pivot's parent does not change throughout the rotation of the tree.
Get rid of the lines that update the parent of the pivot node because
the parent of the pivot stays constant in _rotate_left and
_rotate_right. Lines 278, 279, 295, 296 can be deleted without altering
the functionality of the rotation algorithms and gets rid of the
unneeded code that updates the parent of the pivot node.
In addition, lines 283 and 300 also unnecessarily update the parent of
the pivot node. This can be removed without changing the functionality
of _rotate_left and _rotate_right.
The parent of the pivot node does not change in _rotate_right or
_rotate_left. Delete code that updates the parent of pivot.