Clean up BarChart Functionality#68
Merged
jondot merged 1 commit intojondot:masterfrom Aug 9, 2013
austingulati:bar_charts
Merged
Clean up BarChart Functionality#68jondot merged 1 commit intojondot:masterfrom austingulati:bar_charts
jondot merged 1 commit intojondot:masterfrom
austingulati:bar_charts
Conversation
Owner
|
Hey Austin, sounds really really great, thanks! |
Owner
|
@austingulati hey dude. well apparently after I finished with the cold I had to deal with a break up. so it took some time, sorry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While building a dashboard, I found myself needing the BarChart view. I cleaned it up and added a few features. Notable points:
I haven't worked with d3 in the past so some of my code may not be doing things the d3 way. One concern I have is using calculateX and calculateY that call the x() and y() functions set up by d3. I did this so that it could be extended in the future, for example adding a stacked bar chart would be easy with some simple changes to calculateX and calculateY.
Let me know when you get a chance to take a look at this. I can make changes as necessary.