Conversation
We really are only using it for convenience. Since we rarely change this code. we can take the hit on convenience and inline the functions. We give more concrete types to some of these helpers. We can also remove the use of lenses entirely if it comes to that.
`Data.Functor.Const` didn't exist until 4.9.0.0 of `base`. Rather than use `CPP` extensions, just use the other module that re-exports it.
restyled-io Bot
pushed a commit
that referenced
this pull request
Dec 29, 2020
Query flags result in optional args
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Re: commercialhaskell/stackage#3795