Skip to content

Rest: configure HTTP/1.1 version as default for client instead of request #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henryx merged 1 commit into from
Aug 15, 2023
Merged

Rest: configure HTTP/1.1 version as default for client instead of request #47

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions src/main/java/io/github/jopenlibs/vault/rest/Rest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,7 +423,10 @@ private HttpClient getClient() {
if (configuredClient != null) {
return configuredClient;
}
final var client = HttpClient.newBuilder();
final var client = HttpClient.newBuilder()
//Stick to HTTP/1.1 by default, coz Vault Agent fails proxying h2c request to https
.version(Version.HTTP_1_1);

if (connectTimeoutSeconds != null) {
client.connectTimeout(Duration.of(connectTimeoutSeconds, ChronoUnit.SECONDS));
}
Expand Down Expand Up @@ -465,7 +468,6 @@ private Builder buildRequest(Boolean isGetOrDelete) throws URISyntaxException, R

// Initialize HTTP(S) connection, and set any header values
var request = HttpRequest.newBuilder()
.version(Version.HTTP_1_1)
.uri(uri);

headers.forEach(request::header);
Expand Down