Support Linux #268
Merged
Support Linux #268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Owner
Author
|
The hack I mentioned in my previous comment will no longer be necessary once Carthage/Commandant#80 is included in a release of Commandant. |
Owner
Author
|
Commandant 0.11.2 is out and I've updated this, so the only thing need to run this is |
jpsim
force-pushed
the
jp-spm
branch
2 times, most recently
from
de18b33 to
d35e7b5
Compare
to avoid pyramid of dooooom
since it's just used for debugging purposes. Foundation on Linux doesn't support this option anyway, so removing it now will avoid duplicate codepaths when Linux support is added later.
in preparation for actually compiling on Linux
since Objective-C associated objects aren't available
Owner
Author
|
This is ready for review @norio-nomura. Lots of changes in here, a few of which I'm hoping we can improve. |
Closed
Collaborator
|
Can we add a reference of |
| _ = withUnsafeMutablePointer(to: &array) { arrayPtr in | ||
| sourcekitd_variant_array_apply_f(sourcekitObject, { index, value, context in | ||
| if let value = fromSourceKit(value), let context = context { | ||
| let localArray = context.bindMemory(to: [SourceKitRepresentable].self, capacity: 1) |
Collaborator
There was a problem hiding this comment.
Sorry for late notice.
I guess that this can be assumingMemoryBound(to:) instead of bindMemory(to:capacity:), because context is already initialized before calling withUnsafeMutablePointer(to:).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Targets and depends on #267.
Doesn't build cleanly at the moment due to Commandant pulling in Quick and Nimble when building on Linux, causing conflicts, but the following flow works to build the first time, then
swift buildworks afterwards as long asPackages/and.build/aren't messed with: