Skip to content

Fix array.array.frombytes for Python 3.9#572

Merged
Thrameos merged 3 commits intojpype-project:masterfrom
hugovk:fix-py39
Jan 23, 2020
Merged

Fix array.array.frombytes for Python 3.9#572
Thrameos merged 3 commits intojpype-project:masterfrom
hugovk:fix-py39

Conversation

@hugovk
Copy link
Contributor

@hugovk hugovk commented Jan 23, 2020

Fixes #570.

  • array.fromstring was removed in favour of frombytes in Python 3.9
  • Python 2 has been dropped, remove PyPy2 from CI
  • Sequence is in collections.abc in Python 3.3+. This is commented code, but updated just in case it's uncommented in future

nightly on Travis CI now points to Python 3.9, and it's now green :)

Copy link

@tirkarthi tirkarthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I will leave it maintainers on dropping CI checks/Python 2. Thanks @hugovk

@Thrameos
Copy link
Contributor

Fail is a belch in the CI system.

@Thrameos Thrameos merged commit 8e6bcf6 into jpype-project:master Jan 23, 2020
@hugovk hugovk deleted the fix-py39 branch January 23, 2020 16:33
@hugovk
Copy link
Contributor Author

hugovk commented Jan 23, 2020

Thanks for merge! Do you have a rough schedule for the next release? Cheers!

@Thrameos
Copy link
Contributor

Thrameos commented Jan 23, 2020 via email

@Thrameos
Copy link
Contributor

Thrameos commented Jan 23, 2020 via email

@Thrameos
Copy link
Contributor

@hugovk we have completed a new release. Sorry for the delays.

@hugovk
Copy link
Contributor Author

hugovk commented Feb 29, 2020

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

array.fromstring was removed in favor of tobytes in Python 3.9

3 participants