fix: checking whether the value checked for .trim(), .lowercase() and .uppercase() is a string#2310
Open
fir4tozden wants to merge 1 commit intojquense:masterfrom
Open
fix: checking whether the value checked for .trim(), .lowercase() and .uppercase() is a string#2310fir4tozden wants to merge 1 commit intojquense:masterfrom
.trim(), .lowercase() and .uppercase() is a string#2310fir4tozden wants to merge 1 commit intojquense:masterfrom
Conversation
… and `.uppercase()` is a string
Author
|
Hi @jquense. This pr is important. Please merge. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
.trim(),.lowercase(), and.uppercase()methods do not check whether a value is a string. Therefore, the application crashes if the entered value is not a string.I previously opened an issue for this, but it didn't receive much attention. This is a critical issue, and I wanted to resolve it.
Everything here is as it should be ✅
Everything here is as it should be ✅
But it wasn't supposed to be like this ❌