[Srikanth] | Add Support for rendering Node component props for paren…#247
Closed
srikanthkatta2207 wants to merge 3 commits intojsdf:masterfrom
Closed
[Srikanth] | Add Support for rendering Node component props for paren…#247srikanthkatta2207 wants to merge 3 commits intojsdf:masterfrom
srikanthkatta2207 wants to merge 3 commits intojsdf:masterfrom
Conversation
|
@jsdf any update on this? |
Owner
|
I merged #241 which seems to be the same as this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ever there are multiple parallel tags inside html content, root node component props like numberOfLines not applied properly. So Added the wrapper around domtoElement to apply the nodeComponent props.