Fix error thrown when invalid html for lists#273
Merged
jsdf merged 1 commit intojsdf:masterfrom Jul 25, 2020
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently if invalid markup for Lists/List Items is passed to the component, an uncaught error is thrown and it doesn't die gracefully. The code assumes that all
<li>nodes have a parent<ul>. With this assumption, the code attempts to check the parent's name:parent.name. If invalid markup is passed, parent is undefined, so the uncaught error reads "TypeError: Cannot read property 'name' of undefined"Invalid markup that will make it crash:
<li> <ul> <li>Fine & Visual Art</li> <li>Vocal Music</li> <li>Instrumental</li> </ul>Since we cannot assume the correct markup in this scenario, this fix will ignore
<li>without a parent node and won't render anything.P.S. This is my first react-native commit, so please let me know if I can improve upon anything. Thanks!