Skip to content

fix "bold tags stopped working after updating to React Native" (issue #276) #290

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jsdf merged 2 commits into from
Jul 25, 2020
Merged

fix "bold tags stopped working after updating to React Native" (issue #276) #290

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b0fc515
fix: fontWeight = bold instead fontWeight = 500
misaeldossantos Mar 12, 2020
fd55f60
fix: fontWeight = bold instead fontWeight = 500
misaeldossantos Mar 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions HTMLView.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import PropTypes from 'prop-types';
import htmlToElement from './htmlToElement';
import {Linking, Platform, StyleSheet, View, ViewPropTypes} from 'react-native';

const boldStyle = {fontWeight: '500'};
const boldStyle = {fontWeight: 'bold'};
const italicStyle = {fontStyle: 'italic'};
const underlineStyle = {textDecorationLine: 'underline'};
const strikethroughStyle = {textDecorationLine: 'line-through'};
Expand All @@ -20,15 +20,15 @@ const baseStyles = StyleSheet.create({
pre: codeStyle,
code: codeStyle,
a: {
fontWeight: '500',
fontWeight: 'bold',
color: '#007AFF',
},
h1: {fontWeight: '500', fontSize: 36},
h2: {fontWeight: '500', fontSize: 30},
h3: {fontWeight: '500', fontSize: 24},
h4: {fontWeight: '500', fontSize: 18},
h5: {fontWeight: '500', fontSize: 14},
h6: {fontWeight: '500', fontSize: 12},
h1: {fontWeight: 'bold', fontSize: 36},
h2: {fontWeight: 'bold', fontSize: 30},
h3: {fontWeight: 'bold', fontSize: 24},
h4: {fontWeight: 'bold', fontSize: 18},
h5: {fontWeight: 'bold', fontSize: 14},
h6: {fontWeight: 'bold', fontSize: 12},
});

const htmlToElementOptKeys = [
Expand Down