Added Ace editor multiple cursors functionality and example#927
Open
triglian wants to merge 5 commits intojsfiddle:developfrom
Open
Added Ace editor multiple cursors functionality and example#927triglian wants to merge 5 commits intojsfiddle:developfrom
triglian wants to merge 5 commits intojsfiddle:developfrom
Conversation
Contributor
|
Is there a way to add ACE via a CDN? (for the example?) – it's a big addition to the repository. (Really it might be best if the site wasn't in the same repo as the client code, but it's kind of a big change to extract that right now.) |
Contributor
There was a problem hiding this comment.
You can just do if (msg === undefined) here
- add handler for idle, status and url updates
|
Looking forward for this merge, I'm really needing this feature. |
Author
|
Feature-wise it is complete, my comments are about code conventions mostly. If @ianb has any suggestion I'll be happy to work on it. |
|
+1 |
|
+1, awesome. Would also like to see this feature in place! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is my first attempt on multiple cursors for ace editors. Feedback is more than welcome.
One problem I have is that
TogetherJSConfig_dontShowClicksdoesn't work for an ace editor, see the example here: https://github.com/triglian/togetherjs/blob/develop/site/examples/acecursors/index.html#L36