Fix exports for some bundlers#166
Merged
blakeembrey merged 1 commit intojshttp:masterfrom Oct 2, 2024
proudparrot2:patch-1
Merged
Fix exports for some bundlers#166blakeembrey merged 1 commit intojshttp:masterfrom proudparrot2:patch-1
blakeembrey merged 1 commit intojshttp:masterfrom
proudparrot2:patch-1
Conversation
Member
|
While this is a good change and likely to land here, you might want to report that as a bug to them. The default behavior when |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've been using this package in a javascript library with esbuild and it's worked fine, but for some reason, rspack can't resolve it. Adding
"main": "index.js"to package.json fixed this.