Update MD_HEADER_REGEXP to require at least 4 equals signs#16
Closed
Ayoub-Mabrouk wants to merge 1 commit into
Closed
Update MD_HEADER_REGEXP to require at least 4 equals signs#16Ayoub-Mabrouk wants to merge 1 commit into
Ayoub-Mabrouk wants to merge 1 commit into
Conversation
Member
|
Hey @Ayoub-Mabrouk! Thanks for this PR! While the readability is much better the performance has being decreased. I created this small POC to showcase the difference |
Member
|
Also, we will be getting rid of this integration in the near future. I would not worry too much about the readability OR the performance for this. expressjs/discussions#293 EDIT: Oops, I did not mean to click the close button. That said, @Ayoub-Mabrouk I would recommend engaging in the thread I linked and maybe you can help us improve the history files for the entire project? Feel free to re-open if you would rather continue to engage on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

updates the regular expression for validating the header in HISTORY.md. The new pattern enforces at least 4 consecutive equals signs (=) instead of any number of equals signs.
Changes:
Old RegExp: /^====*$/ (allowed any number of equals signs).
New RegExp: /^={4,}$/ (requires at least 4 equals signs).
Rationale:
This ensures a more consistent and readable header format in HISTORY.md