Reverting FindIconForKey to return null if no icon found (Issue #119 and #28)#121
Merged
Merged
Conversation
…uitable icon can be provided for whatever reason as throwing an exception without also adapting the renderers breaks things for virtually everyone who uses data binding as can be seen in jsmarcus#119 and jsmarcus#28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 6638c67#diff-913f8d5c561cd24bc687f40058980ae2 the behavior of FindIconForKey was changed from returning null to throwing an exception when no suitable icon is found. This might look like a good idea at first as it certainly helps dealing with misspelled icon names but it breaks things for people using data binding where it is common that iconKey will be null at first. The related issues are #119 and #28.
I suggest to revert to the original behavior until a better solution has been found.