Skip to content

[Draft] Decimal Precision #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
TotalTechGeek wants to merge 15 commits into
base: master
Choose a base branch
from
Open

[Draft] Decimal Precision #40

Changes from 1 commit
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
5d42405
Simplify min / max implementation. We need to decide if this is stric…
TotalTechGeek Dec 26, 2024
9303e8c
Implement precision mechanism for JSON Logic; I'll probably release t…
TotalTechGeek Dec 27, 2024
41ec175
Get rid of flags that did nothing
TotalTechGeek Dec 27, 2024
e3b45f5
Rewrite cat, simplify some things w/r/t the precision downgrade... I …
TotalTechGeek Dec 27, 2024
bd9bebc
Implement miscellaneous fixes and test a handful of setups for precis…
TotalTechGeek Dec 27, 2024
eb05083
Tweak tests and precision accuracy
TotalTechGeek Dec 27, 2024
7a74c0d
Add decimal precision to tests
TotalTechGeek Dec 27, 2024
62b4f4e
Add `configurePrecision` to the library
TotalTechGeek Dec 27, 2024
b728b89
Added some comments to `configurePrecision`
TotalTechGeek Dec 27, 2024
1c8854d
Improve precision compatibility further (for when JSON is parsed with…
TotalTechGeek Dec 27, 2024
5feb258
Strict Equality Numeric Promotion
TotalTechGeek Dec 27, 2024
31cbb88
Exclude precision from npmignore
TotalTechGeek Dec 27, 2024
6942255
Add another precision mode that is zero dep but improves accuracy for…
TotalTechGeek Dec 27, 2024
4e90c50
Additional precision tweaks...
TotalTechGeek Dec 27, 2024
272d4ba
Add `+` unary fix
TotalTechGeek Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Add + unary fix
  • Loading branch information
@TotalTechGeek
TotalTechGeek committed Dec 27, 2024
commit 272d4ba90c13a265821f78072d7d186bbb91ee19
9 changes: 5 additions & 4 deletions precision/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,14 +300,15 @@ export function configurePrecision (engine, constructor, compatible = true) {
let overflow = 0
for (let i = 0; i < data.length; i++) {
const item = +data[i]
if (Number.isInteger(data[i])) res += item
if (Number.isInteger(item)) res += item
else {
res += item | 0
overflow += +('0.' + item.toString().split('.')[1]) * 1e6
}
}

return res + (overflow / 1e6)
}, { deterministic: true, sync: true })
}, { deterministic: true, sync: true, optimizeUnary: true })

engine.addMethod('*', (data) => {
const SCALE_FACTOR = 1e6 // Fixed scale for precision
Expand Down Expand Up @@ -344,14 +345,14 @@ export function configurePrecision (engine, constructor, compatible = true) {
let overflow = 0
for (let i = 1; i < data.length; i++) {
const item = +data[i]
if (Number.isInteger(data[i])) res -= item
if (Number.isInteger(item)) res -= item
else {
res -= item | 0
overflow += +('0.' + item.toString().split('.')[1]) * 1e6
}
}
return res - (overflow / 1e6)
}, { deterministic: true, sync: true })
}, { deterministic: true, sync: true, optimizeUnary: true })

engine.addMethod('%', (data) => {
let res = data[0]
Expand Down
Loading