Change to SPDX License Identifier (BSD-3-Clause) for composer - #10
Merged
Conversation
Collaborator
|
Looks good - thanks for the change |
justinrainbow
added a commit
that referenced
this pull request
May 13, 2012
Change to SPDX License Identifier (BSD-3-Clause) for composer
Contributor
Author
|
Thank you for your feedback! |
hakre
pushed a commit
to hakre/json-schema
that referenced
this pull request
Mar 26, 2015
Change to SPDX License Identifier (BSD-3-Clause) for composer
DannyvdSluijs
pushed a commit
that referenced
this pull request
Jul 3, 2026
Trying to run composer in a PHP build without ext-filter fails with:
Error: Call to undefined function JsonSchema\Uri\filter_var()
Fatal error: Uncaught Error: Call to undefined function JsonSchema\Uri\filter_var() in phar:///*redacted*/bin/composer/vendor/justinrainbow/json-schema/src/JsonSchema/Uri/UriResolver.php:84
Stack trace:
#0 phar:///*redacted*/bin/composer/vendor/justinrainbow/json-schema/src/JsonSchema/SchemaStorage.php(100): JsonSchema\Uri\UriResolver->resolve('*redacted*...', 'internal://prov...')
#1 phar:///*redacted*/bin/composer/vendor/justinrainbow/json-schema/src/JsonSchema/SchemaStorage.php(76): JsonSchema\SchemaStorage->expandRefs(Object(stdClass), 'internal://prov...')
#2 phar:///*redacted*/bin/composer/vendor/justinrainbow/json-schema/src/JsonSchema/Validator.php(67): JsonSchema\SchemaStorage->addSchema('internal://prov...', Object(stdClass))
#3 phar:///*redacted*/bin/composer/src/Composer/Json/JsonFile.php(258): JsonSchema\Validator->validate(Object(stdClass), Object(stdClass))
#4 phar:///*redacted*/bin/composer/src/Composer/Json/JsonFile.php(214): Composer\Json\JsonFile::validateJsonSchema('./composer.json', Object(stdClass), 1, '*redacted*...')
#5 phar:///*redacted*/bin/composer/src/Composer/Factory.php(313): Composer\Json\JsonFile->validateSchema(1)
#6 phar:///*redacted*/bin/composer/src/Composer/Factory.php(631): Composer\Factory->createComposer(Object(Composer\IO\ConsoleIO), './composer.json', true, '*redacted*...', true, false)
#7 phar:///*redacted*/bin/composer/src/Composer/Console/Application.php(629): Composer\Factory::create(Object(Composer\IO\ConsoleIO), NULL, true, false)
#8 phar:///*redacted*/bin/composer/src/Composer/Console/Application.php(538): Composer\Console\Application->getComposer(false, true)
#9 phar:///*redacted*/bin/composer/src/Composer/Console/Application.php(485): Composer\Console\Application->hintCommonErrors(Object(Error), Object(Symfony\Component\Console\Output\ConsoleOutput))
#10 phar:///*redacted*/bin/composer/vendor/symfony/console/Application.php(171): Composer\Console\Application->doRun(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#11 phar:///*redacted*/bin/composer/src/Composer/Console/Application.php(141): Symfony\Component\Console\Application->run(Object(Symfony\Component\Console\Input\ArgvInput), Object(Symfony\Component\Console\Output\ConsoleOutput))
#12 phar:///*redacted*/bin/composer/bin/composer(112): Composer\Console\Application->run()
#13 /*redacted*/bin/composer(29): require('*redacted*...')
#14 {main}
thrown in phar:///*redacted*/bin/composer/vendor/justinrainbow/json-schema/src/JsonSchema/Uri/UriResolver.php on line 84
Error: Process completed with exit code 255.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
composer validatecommand is now supporting SPDX license identifers.As your package is used within the codebase (and has a composer.json file) I kindly ask to change the license identifier in composer.json from
NewBSDtoBSD-3-Clause(BSD 3-clause "New" or "Revised" License).This suggestion has been done in good faith and is not a change of the license, just the way how it is identified. See as well composer.json license property.
License text:
LICENSEfile 69af698Text Reviewed against: http://spdx.org/licenses/BSD-3-Clause (git vcs)
Review: Placeholders are filled in, no other differences than whitespace.
Review result: Match
Review result license identifier:
BSD-3-Clause