Skip to content

[BUGFIX] Add '?' for query string during URI generation #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bighappyface merged 1 commit into from
Jun 5, 2017
Merged

[BUGFIX] Add '?' for query string during URI generation #425

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/JsonSchema/Uri/UriResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,8 +61,8 @@ public function generate(array $components)
. $components['authority']
. $components['path'];

if (array_key_exists('query', $components)) {
$uri .= $components['query'];
if (array_key_exists('query', $components) && strlen($components['query'])) {
$uri .= '?' . $components['query'];
}
if (array_key_exists('fragment', $components)) {
$uri .= '#' . $components['fragment'];
Expand Down
18 changes: 18 additions & 0 deletions tests/Uri/UriResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,4 +172,22 @@ public function testResolveEmpty()
)
);
}

public function testReversable()
{
$uri = 'scheme://user:password@authority/path?query#fragment';
$split = $this->resolver->parse($uri);

// check that the URI was split as expected
$this->assertEquals(array(
'scheme' => 'scheme',
'authority' => 'user:password@authority',
'path' => '/path',
'query' => 'query',
'fragment' => 'fragment'
), $split);

// check that the recombined URI matches the original input
$this->assertEquals($uri, $this->resolver->generate($split));
}
}