Skip to content

Enhancement: Add .editorconfig#482

Closed
localheinz wants to merge 1 commit into
jsonrainbow:masterfrom
localheinz:feature/editorconfig
Closed

Enhancement: Add .editorconfig#482
localheinz wants to merge 1 commit into
jsonrainbow:masterfrom
localheinz:feature/editorconfig

Conversation

@localheinz

@localheinz localheinz commented Dec 30, 2017 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR

  • adds an .editorconfig

💁‍♂️ For reference, see http://editorconfig.org.

localheinz
localheinz commented Dec 30, 2017
View reviewed changes
Comment thread .editorconfig
trim_trailing_whitespace = false

[*.yml]
indent_size = 2

@localheinz localheinz Dec 30, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this configuration reflects what is mostly used within this project.

@erayd erayd Dec 31, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While these settings may reflect current usage, they aren't necessarily desirable, and we should probably have a discussion around indentation particularly.

I'd rather like to see the entire project move to a 4-space indent, unless anyone else objects. What we have now is largely historical, and comes from a very old codebase with none of the original maintaners remaining.

@localheinz localheinz Dec 31, 2017

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good, @erayd!

@bighappyface bighappyface Oct 21, 2018

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@localheinz shall we move to 4 space indention and move this forward?

@localheinz localheinz Oct 21, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bighappyface

Can do! Been busy today with tax preparation. Taking a look tomorrow!

@localheinz localheinz Oct 24, 2018

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bighappyface

Updated the indentation! 👍

@localheinz localheinz mentioned this pull request Dec 30, 2017
Merged
1 task
@localheinz
localheinz force-pushed the feature/editorconfig branch 2 times, most recently from f5e9fc2 to 3a60c09 Compare October 24, 2018 14:37
@localheinz
localheinz force-pushed the feature/editorconfig branch from 44850ce to 6651e1b Compare June 18, 2019 05:50
@localheinz
localheinz force-pushed the feature/editorconfig branch from 6651e1b to f19a261 Compare June 18, 2019 05:51
@localheinz localheinz closed this Jan 24, 2021
@localheinz
localheinz deleted the feature/editorconfig branch January 24, 2021 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@erayd erayd erayd left review comments
+1 more reviewer
@bighappyface bighappyface bighappyface left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Questions

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@localheinz @erayd @bighappyface