feat: Exclude certain endpoints from media type validation - #544
Merged
bighappyface merged 5 commits intoNov 6, 2018
Conversation
estahn
commented
Nov 6, 2018
estahn
commented
Contributor
- Fixes Ability to disable media type validation for UriRetriever #543 and Mime type for schema issues #540
Contributor
Author
|
@erayd I'm flexible on the naming of the |
bighappyface
reviewed
Nov 6, 2018
Collaborator
|
@estahn is blacklist the correct term? Wouldn't a list of allowed endpoints be a whitelist? |
erayd
requested changes
Nov 6, 2018
- Change stripos to strpos to match case-insensitive - Rename $mediaTypeBlacklist to $allowedInvalidContentTypeEndpoints - Refactor for to foreach
erayd
requested changes
Nov 6, 2018
erayd
left a comment
erayd
left a comment
Contributor
There was a problem hiding this comment.
Looking good - still needs a bit of cleaning up on the names, but otherwise OK 👍.
erayd
approved these changes
Nov 6, 2018
erayd
left a comment
erayd
left a comment
Contributor
There was a problem hiding this comment.
Looks good - thank you for contributing this 👍.
Contributor
|
@bighappyface Your turn :-). |
estahn
changed the title
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.