Conversation
juanfont
force-pushed
the
remove-ephemeral-on-logout
branch
2 times, most recently
from
a25f282 to
a81a5d5
Compare
juanfont
force-pushed
the
remove-ephemeral-on-logout
branch
from
98ee571 to
d53bed6
Compare
kradalby
reviewed
Jan 3, 2023
kradalby
previously approved these changes
Jan 3, 2023
Collaborator
kradalby
left a comment
kradalby
left a comment
There was a problem hiding this comment.
Approved, but rebase ;)
kradalby
previously approved these changes
Jan 4, 2023
Update changelog Use dedicated method to delete
Fetch the machines from headscale
Co-authored-by: Kristoffer Dalby <kristoffer@dalby.cc>
juanfont
force-pushed
the
remove-ephemeral-on-logout
branch
from
3622a5d to
aef2ade
Compare
kradalby
approved these changes
Jan 5, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements #1087, to better adhere to a change on how ephemeral nodes behave on logout in the SaaS https://tailscale.com/blog/ephemeral-logout/.