Merged
Conversation
juanfont
force-pushed
the
delete-routes
branch
2 times, most recently
from
1d5b3d3 to
ee1d7fb
Compare
kradalby
reviewed
Mar 3, 2023
| @@ -535,6 +535,11 @@ func (h *Headscale) RefreshMachine(machine *Machine, expiry time.Time) error { | |||
|
|
|||
| // DeleteMachine softs deletes a Machine from the database. | |||
Collaborator
There was a problem hiding this comment.
What is the difference between hard and soft? why do we have them?
Owner
Author
There was a problem hiding this comment.
Hard actually deletes the entry in the DB, soft just sets the deleted_at field. We do hard when deleting ephemeral nodes.
|
|
||
| // DeleteMachine softs deletes a Machine from the database. | ||
| func (h *Headscale) DeleteMachine(machine *Machine) error { | ||
| err := h.DeleteMachineRoutes(machine) |
Collaborator
There was a problem hiding this comment.
Cant this be done by cascading database deletes?
Owner
Author
There was a problem hiding this comment.
If we would use cascade, we would be using soft deleted in the routes https://stackoverflow.com/a/67751408 and I wanted to hard delete them.
kradalby
approved these changes
Mar 6, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support to delete routes from the CLI and the API.
It also deletes the routes of a machine when it is deleted (#1228)