Skip to content

Update iOS compatibility and added iOS docs#1264

Merged
kradalby merged 8 commits intojuanfont:mainfrom
nicholas-yap:main
Mar 17, 2023
Merged

Update iOS compatibility and added iOS docs#1264
kradalby merged 8 commits intojuanfont:mainfrom
nicholas-yap:main

Conversation

@nicholas-yap
Copy link
Copy Markdown
Contributor

@nicholas-yap nicholas-yap commented Mar 15, 2023 •
edited
Loading

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

@dyaa dyaa mentioned this pull request Mar 16, 2023
Closed
6 tasks
@JCBird1012
Copy link
Copy Markdown

JCBird1012 commented Mar 16, 2023 •
edited
Loading

A part of me wonders if we should additionally add these instructions (or something of the sort) to templates/apple.html?

@nicholas-yap
Copy link
Copy Markdown
Contributor Author

nicholas-yap commented Mar 16, 2023 •
edited
Loading

I was actually working on that! But I wasn't sure if it was needed so I didn't initially commit the change
Anyway I've incorporated some of the instructions into templates/apple.html

kradalby
kradalby reviewed Mar 16, 2023
View reviewed changes
Copy link
Copy Markdown
Collaborator

@kradalby kradalby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks could, could you run the Prettier formatter on the files?

@JCBird1012
Copy link
Copy Markdown

JCBird1012 commented Mar 17, 2023 •
edited
Loading

I wasn’t paying close enough attention to the commit history when I made my earlier suggestion 🫣 - #1261 appears to also have added instructions to templates/apple.html - it looks like this commit might undo some of that work, or modifies it? Might be worth looking into how to reconcile what’s here with what’s there.

@kradalby
Copy link
Copy Markdown
Collaborator

kradalby commented Mar 17, 2023

@JCBird1012 I think it mostly updates and improved the things I added in #1261.

@nicholas-yap @kradalby
Create iOS-client.md
a52b978 
Instructions on configuring iOS clients with headscale
@nicholas-yap @kradalby
Updated ios compatibility
46728c0
@nicholas-yap @kradalby
Updated iOS instructions
cf141bc
@nicholas-yap @kradalby
Update CHANGELOG.md
273257d
@nicholas-yap @kradalby
Update CHANGELOG.md
aa05362
@nicholas-yap @kradalby
Update apple.html
377795e 
Incorporated the instructions from /docs/iOS-client.md. 
Updated Tailscale version number
@nicholas-yap @kradalby
Ran prettier and fixed formatting
a17114c 
Changed the wording and formatting of some instructions
Edited App Store URL to remove region specific addresses and leftover query string
Ran prettier
@nicholas-yap @kradalby
Ran prettier
5121726
@kradalby kradalby merged commit 003036a into juanfont:main Mar 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kradalby kradalby kradalby approved these changes

@juanfont juanfont Awaiting requested review from juanfont juanfont is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nicholas-yap @JCBird1012 @kradalby