fixed the issue of sending on closed channel#542
Merged
kradalby merged 2 commits intojuanfont:mainfrom Apr 11, 2022
mpldr:issue-342-send-on-closed-channel
Merged
fixed the issue of sending on closed channel#542kradalby merged 2 commits intojuanfont:mainfrom mpldr:issue-342-send-on-closed-channel
kradalby merged 2 commits intojuanfont:mainfrom
mpldr:issue-342-send-on-closed-channel
Conversation
Contributor
Author
|
This Commit was also sent to @juanfont 10.04.2022 22:37 UTC. |
This commit fixes the issue of headscale crashing after sending on a closed channel by moving the channel close to the sender side, instead of the creator. closeChanWithLog is also implemented with generics now. Fixes: #342 Signed-off-by: Moritz Poldrack <git@moritz.sh>
Collaborator
|
Happy to merge and test this when the tests pass, can you add an entry to the changelog? |
kradalby
approved these changes
Apr 11, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue of headscale crashing after sending on a
closed channel by moving the channel close to the sender side, instead
of the creator. closeChanWithLog is also implemented with generics now.
Signed-off-by: Moritz Poldrack git@moritz.sh
Fixes #342