Skip to content

Make more sslmode available for postgresql connection (Fixes #925)#927

Merged
kradalby merged 4 commits intojuanfont:mainfrom
OrvilleQ:fix-psql-sslmode
Nov 24, 2022
Merged

Make more sslmode available for postgresql connection (Fixes #925)#927
kradalby merged 4 commits intojuanfont:mainfrom
OrvilleQ:fix-psql-sslmode

Conversation

@OrvilleQ
Copy link
Copy Markdown
Contributor

@OrvilleQ OrvilleQ commented Nov 3, 2022

  • read the CONTRIBUTING guidelines
  • raised a GitHub issue or discussed it on the projects chat beforehand
  • added unit tests
  • added integration tests
  • updated documentation if needed
  • updated CHANGELOG.md

#925

Change DBssl to String while still compatible with old boolean configuration.

@OrvilleQ OrvilleQ changed the title Fixes #925 Make more sslmode available for postgresql connection (Fixes #925) Nov 11, 2022
@OrvilleQ OrvilleQ force-pushed the fix-psql-sslmode branch 2 times, most recently from c449c2f to c95c6ca Compare November 18, 2022 07:12
@OrvilleQ
Copy link
Copy Markdown
Contributor Author

@juanfont @kradalby Hello guys.

I know you guys are busy working on the next release, but would you like to take a moment to look at this pull request? Is a small one, and I really hope it can be included in the next release as someone who really needs this fix.

Copy link
Copy Markdown
Collaborator

@kradalby kradalby left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologise for the delay, one question, two nits.

Comment thread config-example.yaml Outdated
Comment thread app.go Outdated
kradalby
kradalby previously approved these changes Nov 24, 2022
@kradalby
Copy link
Copy Markdown
Collaborator

oh, apologies, could you also add a CHANGELOG.md entry for this change? otherwise good!

@OrvilleQ
Copy link
Copy Markdown
Contributor Author

oh, apologies, could you also add a CHANGELOG.md entry for this change? otherwise good!

Sure, I've done it.

@kradalby kradalby merged commit 25195b8 into juanfont:main Nov 24, 2022
@OrvilleQ OrvilleQ deleted the fix-psql-sslmode branch December 31, 2022 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants