Add build flag to enable TS2019#928
Merged
kradalby merged 3 commits intojuanfont:mainfrom Nov 4, 2022
Merged
Conversation
kradalby
force-pushed
the
experiment-disable-ts2019
branch
from
efd044d to
51ca53f
Compare
kradalby
force-pushed
the
experiment-disable-ts2019
branch
from
b650493 to
b9dd251
Compare
This commit starts an experiment to disable TS2019 (we also call it legacy). The two main goals for this right now is: - Diasble TS2019, and verify that the integration test clients with the appropriate TS2021 support works as expected - Get an overview of how coupled the protocol code is, if this is easy, it will be easy to remove when the time comes. Also, users with "crazy" desires like only supporting the most modern protocol _can_ build this version. Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
Signed-off-by: Kristoffer Dalby <kristoffer@tailscale.com>
kradalby
force-pushed
the
experiment-disable-ts2019
branch
from
b9dd251 to
2582ffa
Compare
juanfont
approved these changes
Nov 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit starts an experiment to disable TS2019 (we also call it
legacy).
The two main goals for this right now is:
appropriate TS2021 support works as expected
it will be easy to remove when the time comes.
Also, users with "crazy" desires like only supporting the most modern
protocol can build this version.
Signed-off-by: Kristoffer Dalby kristoffer@tailscale.com