add test for julia install and mtime maintenance#200
Merged
IanButterworth merged 2 commits intomasterfrom Jan 5, 2024
Merged
Conversation
IanButterworth
force-pushed
the
ib/mtime_test
branch
from
6ccd6c4 to
b9a927e
Compare
IanButterworth
force-pushed
the
ib/mtime_test
branch
from
b9a927e to
86e3f12
Compare
IanButterworth
changed the title
This was referenced Jan 4, 2024
Contributor
|
Can this PR be closed? Looks like the tests were added in #196 |
Member
Author
|
We decided to merge this separately in a failing state |
omus
approved these changes
Jan 5, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fail on master, and will be added to #196 which should pass
The mtime test only runs on 1.7+ because that's when
pkgdiris available, and the mtime issue isn't really a problem back then. It's more since stdlibs have started to be removed from the sysimage.Interestingly on windows the archive mtimes are maintained, which explains why the cache action works well already on windows julia-actions/cache#85 (comment)